feat: Integrate MinFeeVerifier and DaoScriptSizeVerifier into light-client#216
Merged
feat: Integrate MinFeeVerifier and DaoScriptSizeVerifier into light-client#216
MinFeeVerifier and DaoScriptSizeVerifier into light-client#216Conversation
There was a problem hiding this comment.
Copilot reviewed 4 out of 4 changed files in this pull request and generated no comments.
Comments suppressed due to low confidence (2)
light-client-lib/src/verify.rs:254
- [nitpick] Consider using an explicit conversion method instead of relying on into() here so that the intended type conversion for swc is clearer and more readable.
swc.clone().into(),
light-client-lib/src/tests/verify.rs:43
- Consider adding a test case to verify the error path when the transaction fee is below the minimum fee rate, ensuring that MinFeeVerifier::verify returns an appropriate error.
assert_eq!(fee_calculator.transaction_fee(&rtx).unwrap(), Capacity::shannons(1_0000_0000));
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## develop #216 +/- ##
===========================================
+ Coverage 71.58% 71.90% +0.32%
===========================================
Files 27 27
Lines 6925 6966 +41
===========================================
+ Hits 4957 5009 +52
+ Misses 1968 1957 -11
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Officeyutong
changed the title
MinFeeVerifier and DaoScriptSizeVerifier into light-client
quake
approved these changes
Jun 13, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds min fee check and DAO script size check when sending transactions through light client
send_transactionwill get their fee rate calculated, and compared to a pre-set fixed fee rate (1000 shannon per kilobytes). Transactions with insufficient fee rate will be rejected bysend_transaction.DaoScriptSizeVerifier.